[PATCH] D98865: [AMDGPU] Disable forceful inline of non-kernel functions which use LDS.

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Looks good to me. This will presumably increase the uses of the lower module lds pass. Maybe prudent to run it through the gerrit CI infra before landing?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:196
 
-static cl::opt<bool>
-    DisableLowerModuleLDS("amdgpu-disable-lower-module-lds", cl::Hidden,
-                          cl::desc("Disable lower module lds pass"),
-                          cl::init(false));
+static cl::opt<bool, true> EnableLowerModuleLDS(
+    "amdgpu-enable-lower-module-lds", cl::desc("Enable lower module lds pass"),
----------------
Enable reads better than disable, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98865/new/

https://reviews.llvm.org/D98865