[PATCH] D98743: [flang] Order Symbols by source provenance

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Hi @klausler , looks like this patch is causing failures in one of our public builders:

- http://lab.llvm.org:8011/#/builders/33

  ******************** TEST 'Flang :: Semantics/resolve102.f90' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/test/Semantics/test_errors.sh /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/test/Semantics/resolve102.f90 /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/tools/flang/test/Semantics/Output/resolve102.f90.tmp /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/bin/f18 -intrinsic-module-directory /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/include/flang
  --
  Exit Code: 1
  Command Output (stdout):
  --
  /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/bin/f18 -intrinsic-module-directory /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/include/flang -fsyntax-only /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/test/Semantics/resolve102.f90
  expect at 84: 'p2' must be an abstract interface or a procedure with an explicit interface
  --
  Command Output (stderr):
  --
  + : 'RUN: at line 1'
  + /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/test/Semantics/test_errors.sh /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/test/Semantics/resolve102.f90 /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/tools/flang/test/Semantics/Output/resolve102.f90.tmp /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/bin/f18 -intrinsic-module-directory /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/build/include/flang
  test_errors.sh: FAIL
  --
  ********************

You can reproduce this with `clang` (I used `clang-10`). Also, use `libc++` rather than `libstdc++` (`-DLLVM_ENABLE_LIBCXX=On'). That's what's unique about this particular builder.

Could you take a look? I couldn't find a fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98743/new/

https://reviews.llvm.org/D98743