[PATCH] D98861: [CMAKE] Fix cross-compilation build

Abhina Sree via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 06:49:14 PDT 2021


abhina.sreeskantharajan added a comment.

In D98861#2634455 <https://reviews.llvm.org/D98861#2634455>, @jhenderson wrote:

> Is this approach going to work for all the previous cases we've identified as problematic (and hence why we ended up with this approach)? In other words, is there a risk that this will actually cause things to regress in some cases?

I think if we cross-compile for a Windows platform we may see regressions. We will default to python's os.strerror() which is incorrect casing on Windows (This won't affect Cygwin and MSYS environments though).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98861/new/

https://reviews.llvm.org/D98861



More information about the llvm-commits mailing list