[PATCH] D98851: [OCaml] Add (get/set)_module_identifer functions

[Josh Berdine via Phabricator via llvm-commits]

jberdine accepted this revision.
jberdine added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/bindings/ocaml/llvm/llvm.mli:550
+
+(** [set_module_identifier m id] Sets the module identifier of [m]
+    to [id]. See the method [llvm::Module::setModuleIdentifier] *)
----------------



================
Comment at: llvm/bindings/ocaml/llvm/llvm_ocaml.c:47
 
 CAMLprim value cstr_to_string(const unsigned char *Str, unsigned Len) {
   CAMLparam0();
----------------
It might be more clear to use mlsize_t as that is what caml_alloc_string requires, and push any conversion that might be needed to the clients.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98851/new/

https://reviews.llvm.org/D98851