[PATCH] D98809: [NFC] Enable RVALUE_REFERENCE_THIS on MSVC 2019

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

In D98809#2634314 <https://reviews.llvm.org/D98809#2634314>, @njames93 wrote:

> In D98809#2634224 <https://reviews.llvm.org/D98809#2634224>, @aaron.ballman wrote:
>
>> Aside: I wonder what our support policy is for MSVC 2017. Once upon a time, we would care about the last two major releases of a compiler, but now that 2019 has gone through 9 updates I'm starting to wonder if that's changed our policy for MSVC (aka, can we drop support for 2017 entirely?).
>
> I'm no expert in this regard but I don't see a reason for dropping compiler support for the sake of dropping it.

It boils down to maintenance burden -- we're working around an MSVC 2017 issue (and this isn't the only one), so it's reasonable to consider whether we need to continue to pay that cost or not.

> There's also more than likely some users still using 2017 for their own reasons and we shouldn't just disregard them.

Strongly agreed, and definitely not as part of this patch. It'd require wider community discussion. It was more a remark that I'm no longer certain the status quo for when we drop support for compilers still makes sense with the new release model for MSVC. "Last two releases" is harder to judge when we use the date in the product title to decide what constitutes a release and the date no longer changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98809/new/

https://reviews.llvm.org/D98809