[PATCH] D98659: [MachineCopyPropagation] Do more backward copy propagations

[yshui via Phabricator via llvm-commits]

yshui added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:88
 
+/// Check that \p MI does not have implicit uses that overlap with it's \p Use
+/// operand (the register being replaced), since these can sometimes be
----------------
lkail wrote:
> yshui wrote:
> > lkail wrote:
> > > Any reason of moving these two functions?
> > I realized these two functions don't have to be part of CopyTracker. If this is not fine I can put them back.
> I would prefer leave them as they are to make code diff less noisy. If you have strong desire to move, please post another NFC patch.
Ah, sorry, my mistake. These functions were originally in `class MachineCopyPropagation`, but I needed them in `class CopyTracker`, so I moved them out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98659/new/

https://reviews.llvm.org/D98659