[PATCH] D98659: [MachineCopyPropagation] Do more backward copy propagations

[Kai Luo via Phabricator via llvm-commits]

lkail added a comment.

> Thanks for your review. There is a test case in https://reviews.llvm.org/D98401, which is quite big. I wasn't able to reduce it further, is it OK to just include that as test case?

Have you tried using bugpoint to reduce it further, or writing MIR test manually?



================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:88
 
+/// Check that \p MI does not have implicit uses that overlap with it's \p Use
+/// operand (the register being replaced), since these can sometimes be
----------------
yshui wrote:
> lkail wrote:
> > Any reason of moving these two functions?
> I realized these two functions don't have to be part of CopyTracker. If this is not fine I can put them back.
I would prefer leave them as they are to make code diff less noisy. If you have strong desire to move, please post another NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98659/new/

https://reviews.llvm.org/D98659