[PATCH] D98853: [test] Fix incorrect use of string variable use
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 18 03:56:14 PDT 2021
thopre created this revision.
thopre added reviewers: tellenbach, ostannard, samparker, chill, pbarrio.
Herald added a subscriber: kristof.beyls.
thopre requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
LLVM test CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll uses
a string substitution block that contains a regex matching block. This
seems like as a copy/paste from other similar test where the match also
defines a variable, hence the [[]] syntax. In this case however this is
a CHECK-NOT variable so nothing should match. No variable definition is
thus expected and the square brackets can be dropped.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D98853
Files:
llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll
Index: llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll
===================================================================
--- llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll
+++ llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll
@@ -67,7 +67,7 @@
attributes #0 = { "sign-return-address"="non-leaf" }
-; CHECK-NOT: [[OUTLINED_FUNCTION_{{.*}}]]
+; CHECK-NOT: OUTLINED_FUNCTION_{{.*}}
; CHECK-NOT: .cfi_b_key_frame
; CHECK-NOT: paci{{[a,b]}}sp
; CHECK-NOT: hint #2{{[5,7]}}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98853.331512.patch
Type: text/x-patch
Size: 566 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210318/5f3e8e7f/attachment.bin>
More information about the llvm-commits
mailing list