[PATCH] D98706: [SCEV] Add false->any implication

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

In D98706#2634090 <https://reviews.llvm.org/D98706#2634090>, @mkazantsev wrote:

> In D98706#2629115 <https://reviews.llvm.org/D98706#2629115>, @lebedev.ri wrote:
>
>> That being said, i think i'm failing to understand why it implies *anything*?
>
> Just by definition of implication: https://en.wikipedia.org/wiki/Truth_table#Logical_implication

Right, thanks for reminding me of that.

> In terms of compiler code, "guarded by false" means unreachable code, and basically any transform there is legal.

Right. Iff the "guarded by false" dominates the code. (i.e. the code can only be reached through the guard)

With that spelled out explicitly, this looks good to me, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98706/new/

https://reviews.llvm.org/D98706