[PATCH] D98659: [MachineCopyPropagation] Do more backward copy propagations

yshui via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 03:39:19 PDT 2021


yshui added a comment.

In D98659#2633657 <https://reviews.llvm.org/D98659#2633657>, @lkail wrote:

> In D98659#2632859 <https://reviews.llvm.org/D98659#2632859>, @yshui wrote:
>
>> Since this patch already changed output of many test cases, do we still need a test case specifically for this patch?
>
> You'd better add some mir tests to demonstrate the idea, w/o `-g`.

Thanks for your review. There is a test case in https://reviews.llvm.org/D98401, which is quite big. I wasn't able to reduce it further, is it OK to just include that as test case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98659/new/

https://reviews.llvm.org/D98659



More information about the llvm-commits mailing list