[PATCH] D95478: [llvm-objcopy][NFC][Wasm] Do not use internal buffer while writing into the output.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 01:46:13 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: llvm/tools/llvm-objcopy/wasm/Writer.cpp:65
+  support::endian::write32le(&Version, Obj.Header.Version);
+  Out.write((const char *)&Version, sizeof(Version));
 
----------------
I think prefer reinterpret_cast here and below, since that was the style that was there before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95478/new/

https://reviews.llvm.org/D95478



More information about the llvm-commits mailing list