[PATCH] D98582: [llvm-objcopy][NFC] remove split dwo file creation from executeObjcopyOnBinary.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 01:03:43 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.

LGTM.



================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:377-378
+      Config.StripDWO = false;
+      // Copy .dwo tables from the Config.InputFilename into Config.SplitDWO
+      // file using specified ObjcopyFunc function.
+      if (Error E = writeToFile(Config.SplitDWO, ObjcopyFunc))
----------------
A bit more verbose than I had in mind, but it's fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98582/new/

https://reviews.llvm.org/D98582



More information about the llvm-commits mailing list