[PATCH] D98679: [ELF] Change --shuffle-sections=<seed> to --shuffle-sections=<section-glob>=<seed>

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 01:01:35 PDT 2021


jhenderson added inline comments.


================
Comment at: lld/test/ELF/shuffle-sections.s:51
+
+# USAGE: error: --shuffle-sections=: expected <section_glob>=<seed>, but got '{{.*}}'
+
----------------
I think it would be a good idea to check the exact string here, to show we're not printing garbage. You can use FileCheck -D to easily do that without needing to duplicate this line per case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98679/new/

https://reviews.llvm.org/D98679



More information about the llvm-commits mailing list