[PATCH] D98789: [PEI] add dwarf information for stack probe

YangKeao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 00:44:28 PDT 2021


YangKeao marked an inline comment as done.
YangKeao added inline comments.


================
Comment at: llvm/test/CodeGen/X86/stack-clash-unknown-call.ll:19
+;CHECK-NEXT:	.cfi_adjust_cfa_offset 3912
 ;CHECK-NEXT:	.cfi_def_cfa_offset 8016
 ;CHECK-NEXT:	movq	%rsp, %rdi
----------------
nagisa wrote:
> The `def_cfa_offset` is superfluous here now. The last `cfi` directive should be either the `adjust` or `def`.
> The `def_cfa_offset` is superfluous here now. The last `cfi` directive should be either the `adjust` or `def`.




================
Comment at: llvm/test/CodeGen/X86/stack-clash-unknown-call.ll:19
+;CHECK-NEXT:	.cfi_adjust_cfa_offset 3912
 ;CHECK-NEXT:	.cfi_def_cfa_offset 8016
 ;CHECK-NEXT:	movq	%rsp, %rdi
----------------
YangKeao wrote:
> nagisa wrote:
> > The `def_cfa_offset` is superfluous here now. The last `cfi` directive should be either the `adjust` or `def`.
> > The `def_cfa_offset` is superfluous here now. The last `cfi` directive should be either the `adjust` or `def`.
> 
> 
Fixed by removing the last `adjust`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98789/new/

https://reviews.llvm.org/D98789



More information about the llvm-commits mailing list