[PATCH] D98762: [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 00:42:19 PDT 2021


MaskRay added a comment.

In D98762#2632337 <https://reviews.llvm.org/D98762#2632337>, @ychen wrote:

> I mean ".lto_module" reveals the marker function explicitly. I'm fine with only using ".lto_discard" though. I could add comments to explain the usage above `parseDirectiveLTODiscard`. Please let me know your preference.

I prefer only using `.lto_discard`. `.lto_module` adds unneeded code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98762/new/

https://reviews.llvm.org/D98762



More information about the llvm-commits mailing list