[PATCH] D98789: [PEI] add dwarf information for stack probe

YangKeao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 22:22:26 PDT 2021


YangKeao added a comment.

In D98789#2632702 <https://reviews.llvm.org/D98789#2632702>, @efriedma wrote:

> To clarify, I've done some more reading now, and figured out where I went wrong.  For a long time, LLVM did not emit accurate unwind info to describe the prologue/epilogue (and still doesn't on some targets), so I was under the impression it wasn't possible.  Clearly, it is, and it's implemented on x86.
>
> -----
>
> The change to use r11 isn't implemented correctly: we can't adjust the stack pointer until *after* we've probed the relevant pages.  It'll appear to work, but it won't actually provide complete protection if a signal handler triggers at the wrong time.

Make sense. How about use `r11 + offset` as the CFA temporarily?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98789/new/

https://reviews.llvm.org/D98789



More information about the llvm-commits mailing list