[PATCH] D98323: [lld-macho] implement options -map

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:830
 
+  config->mapFile = args.getLastArgValue(OPT_map);
   config->outputFile = args.getLastArgValue(OPT_o, "a.out");
----------------
oontvoo wrote:
> maybe check and warn if the path is empty?
The empty check is already done in `writeMapFile()`. And I think the option parser will reject something like `-map` without an argument, so we don't need to warn (but I haven't verified this)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98323/new/

https://reviews.llvm.org/D98323