[PATCH] D98785: [Orc] Fix pending debug object tracking in DebugObjectManagerPlugin

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 18:24:55 PDT 2021


lhames added a comment.

> This is hard to reproduce with lli, because single-threaded execution with LLLazyJIT will implicitly sequence materialization. LLJIT instead materializes module dependencies recursively, which makes this issue easy to reproduce. Unfortunately, we have no LLJIT tool that I could use for a test. It's not the first time this limitation comes up for me and I wonder if it's worth adding an orc-greedy kind to lli. What do you think?

I'm 100% in favor of an `-orc-greedy` mode for lli. The only reason it doesn't have one is that I've been short on time.

If it were built I would say that it should just be `-jit-kind=orc` (with `-jit-kind=orc-lazy` remaining as it is), and that it should be the new default. In that case all MCJIT test cases would just have to be updated to explicitly specify `-jit-kind=mcjit`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98785/new/

https://reviews.llvm.org/D98785



More information about the llvm-commits mailing list