[llvm] 792bed6 - Revert "[NewPM] Verify LoopAnalysisResults after a loop pass"

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 15:22:59 PDT 2021


Author: Arthur Eubanks
Date: 2021-03-17T15:22:52-07:00
New Revision: 792bed6a4c37d008c21779befabbc4342978965b

URL: https://github.com/llvm/llvm-project/commit/792bed6a4c37d008c21779befabbc4342978965b
DIFF: https://github.com/llvm/llvm-project/commit/792bed6a4c37d008c21779befabbc4342978965b.diff

LOG: Revert "[NewPM] Verify LoopAnalysisResults after a loop pass"

This reverts commit 6db3ab2903f42712f44000afb5aa467efbd25f35.

Causing too large of compile time regression.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/LoopPassManager.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
index db6661f1071c..60a9602096bb 100644
--- a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
@@ -291,15 +291,8 @@ PreservedAnalyses FunctionToLoopPassAdaptor::run(Function &F,
     else
       PI.runAfterPass<Loop>(*Pass, *L, PassPA);
 
-#ifndef NDEBUG
-    // LoopAnalysisResults should always be valid.
-    // Note that we don't LAR.SE.verify() because that can change observed SE
-    // queries. See PR44815.
-    LAR.DT.verify();
-    LAR.LI.verify(LAR.DT);
-    if (LAR.MSSA)
-      LAR.MSSA->verifyMemorySSA();
-#endif
+    // FIXME: We should verify the set of analyses relevant to Loop passes
+    // are preserved.
 
     // If the loop hasn't been deleted, we need to handle invalidation here.
     if (!Updater.skipCurrentLoop())


        


More information about the llvm-commits mailing list