[PATCH] D98795: [lld-macho][NFC] Minor refactor of Writer::run()

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 14:34:57 PDT 2021


gkm marked 4 inline comments as done.
gkm added inline comments.


================
Comment at: lld/MachO/Writer.cpp:858-859
 
-  // Sort and assign sections to their respective segments. No more sections nor
-  // segments may be created after these methods run.
   createOutputSections();
----------------
int3 wrote:
> This comment seems worth keeping
OK for now ... until BRET (branch-range-extension thunks) creates more sections after this point during address assignment. ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98795/new/

https://reviews.llvm.org/D98795



More information about the llvm-commits mailing list