[PATCH] D98780: [IR] Add opt-in flag to isIndirectCall() to consider inlineasm

Wed Mar 17 13:03:07 PDT 2021

arsenm added a comment.

In D98780#2632576 <https://reviews.llvm.org/D98780#2632576>, @madhur13490 wrote:

> In D98780#2632539 <https://reviews.llvm.org/D98780#2632539>, @arsenm wrote:
>
>> I don't think this should be done. The point of the function is to check if the IR instruction is an indirect call. inline is a different entity
>
> But in that case the current function should not even do anything related to inlineAsm(). Treating the presence of inlineAsm is different for difference clients and that is what the flag offers.

The function should return false for inline asm. Inline asm is not an indirect call, and indirect call here refers to the IR construct for an indirect call. The fact that inline assembly may contain code that performs what will be encoded as an indirect call is not the point here. The IR semantic is not concerned with what happens to come out of codegen

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98780/new/

https://reviews.llvm.org/D98780