[PATCH] D98807: Fix a naming issue in recurrence matcher
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 17 12:46:10 PDT 2021
reames created this revision.
reames added a reviewer: mkazantsev.
Herald added subscribers: dantrushin, hiraditya, mcrosier.
Herald added a reviewer: bollu.
reames requested review of this revision.
Herald added a project: LLVM.
This was brought up in D98222 <https://reviews.llvm.org/D98222>. The recently added matchSimpleRecurrence doesn't actually match a recurrence (oops). It matches something which is nearly a recurrence, but allows one additional free variable.
This patch splits the concept into a true recurrence matcher and a "near" recurrence matcher, and tries to clarify some comments. I'm not particularly a fan of the "near" wording, but I haven't found anything better just yet. Suggestions welcome.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D98807
Files:
llvm/include/llvm/Analysis/ValueTracking.h
llvm/lib/Analysis/ValueTracking.cpp
llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98807.331349.patch
Type: text/x-patch
Size: 7387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210317/69f7f29a/attachment.bin>
More information about the llvm-commits
mailing list