[PATCH] D98222: [SCEV] Use trip count information to improve shift recurrence ranges

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Max, on the terminology bit, I see your point.  I've spent some time thinking about it, and haven't really come up with anything better naming wise.  What we have is a recurrence with one extra free variable.  Said another way, we have a cyclic dependence through the phi and one binop.  Do you have any suggestions on naming here?  The best I've got is matchSimpleRecurrenceWithOneFreeVariable but that's a bit ugly to say the least.  I also considered matchNearRecurrence, but well, defining "near" is ugly too.

I would prefer to separate the naming point from this review though.  While I agree we should change it, it's an issue with existing code and not specific to this use.  Would you be okay with moving forward on this review under the understanding that I tackle the naming/terminology issue separately in the very near future?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98222/new/

https://reviews.llvm.org/D98222