[PATCH] D95380: Turn on the new pass manager by default

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 12:10:47 PDT 2021


aeubanks added a comment.

In D95380#2632044 <https://reviews.llvm.org/D95380#2632044>, @rnk wrote:

> In the context of https://bugs.llvm.org/show_bug.cgi?id=49606, I realized that most developers are probably still using the old pass manager. That issue only repros with the new PM, and @jdoerfert was using the legacy PM. I checked my local build dir, and observed this line in it:
>
>   ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER:BOOL=FALSE
>
> One way to deal with this would be to deprecate the legacy spelling of `ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER` and switch to `LLVM_ENABLE_NEW_PASS_MANAGER`. If we don't do this, we'll have to make a PSA about clearing CMakeCache.txt anyway, so I think it's probably worth it.

I'd prefer not to rename the variable, since it was used in a bunch of communication, and updating bots is a pain. A PSA sounds good though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95380/new/

https://reviews.llvm.org/D95380



More information about the llvm-commits mailing list