[PATCH] D98532: [M68k] Use fixed asm string for MxPseudo instructions

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

In D98532#2629887 <https://reviews.llvm.org/D98532#2629887>, @RKSimon wrote:

> In D98532#2627487 <https://reviews.llvm.org/D98532#2627487>, @myhsu wrote:
>
>> In D98532#2626683 <https://reviews.llvm.org/D98532#2626683>, @RKSimon wrote:
>>
>>> @myhsu Would we be better off adding non-empty asm strings to all uses?
>>
>> Do you mean setting non-empty asm string by default on `MxInst`? I feel like the non-empty string requirement imposed by parser table can help us catch mistakes if we forget to set assembly string for an instruction (in the future), so I'm incline not to do that
>
> I meant just stop MxPseudo taking a default string so all instances include a useful asm comment string.

Ah, using the asm string as comments (for MxPseudo instances), I see. But I don't think these pseudo instructions will ever be printed/parsed to/from assembly. From what I understand they're only syntax sugar for codegen (unlike some of the targets that have assembler pseudo instructions). If that's the case, I don't think it's really necessary to put meaningful string in the assembly string. If we want to add comments, I prefer to put in the TG code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98532/new/

https://reviews.llvm.org/D98532