[PATCH] D98718: [AA][NFC] Convert AliasResult to class containing offset for PartialAlias case.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

@nikic, could you check this patch through the compiler-tracker, please?



================
Comment at: llvm/include/llvm/Analysis/MemorySSA.h:304
+      MemoryAccess *DMA, bool Optimized = false,
+      Optional<AliasResult> AR = AliasResult(AliasResult::MayAlias)) {
     if (!Optimized) {
----------------
dfukalov wrote:
> Perhaps `AliasResult` should be replaced with `AliasResult::Result` here and in similar places in MemorySSA? @nikic, @asbirlea, what do you think?
Yes. Unless we have a usecase of using the PartialAlias in MemorySSA, I don't think we should have the overhead of creating new class instances for all aliasing result kept in optimized memory accesses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98718/new/

https://reviews.llvm.org/D98718