[PATCH] D98534: [M68k] Introduce DReg bead

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 11:32:14 PDT 2021


myhsu added a comment.

In D98534#2630064 <https://reviews.llvm.org/D98534#2630064>, @ricky26 wrote:

> It acts like a default when decoding (in one of the later patches). The DA bead is still needed since it's used for instructions where it can be either an address or data register.
>
> As it stands, I could rename it but it might be a bit misleading. (Existing cases which don't need a specific register kind would all use `AReg`.)

Ahh I see

> Alternatively, perhaps I could add `AReg` and enforce that `DReg`/`AReg` cannot be combined with `DA` and keep `Reg` separate, solely for use with `DA`. I didn't think of that at the time.

Let's keep your current plan (i.e. only add DReg) for now. Since if `Reg` and `DA` are really needed I don't see a good reason to add another `AReg` if that doesn't really make implementing MCCodeEmitter or AsmParser easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98534/new/

https://reviews.llvm.org/D98534



More information about the llvm-commits mailing list