[PATCH] D98778: [DAG] SelectionDAG::isSplatValue - add ISD::ABS handling

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 11:24:27 PDT 2021


tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

Awesome, thanks for picking this up. LGTM with the TODO restored :)



================
Comment at: llvm/test/CodeGen/WebAssembly/simd-shift-complex-splats.ll:9-10
 
-;; TODO: Optimize this further by scalarizing the add
-
 ; CHECK-LABEL: shl_add:
----------------
I think this TODO still applies because the adds haven't yet been scalarized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98778/new/

https://reviews.llvm.org/D98778



More information about the llvm-commits mailing list