[PATCH] D88232: [DebugInfo] Handle multiple variable location operands in IR

Wed Mar 17 09:49:09 PDT 2021

StephenTozer added a comment.

In D88232#2631602 <https://reviews.llvm.org/D88232#2631602>, @hans wrote:

> This caused non-deterministic output from the compiler, see https://bugs.chromium.org/p/chromium/issues/detail?id=1189090#c8 for a reproducer. (Usually this is due to non-deterministic iteration order for hash-based data structures such as DenseMap)
>
> I've reverted in 01ac6d1587e8613ba4278786e8341f8b492ac941 <https://reviews.llvm.org/rG01ac6d1587e8613ba4278786e8341f8b492ac941> until it can be fixed.

Resubmitted, should be fixed now - instructions were being inserted while iterating through a map, the map type has been changed from `SmallDenseMap` to `MapVector` now, so there should no longer be any non-determinism.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88232/new/

https://reviews.llvm.org/D88232