[PATCH] D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 08:32:58 PDT 2021


shchenz added a comment.

Thanks for review @echristo

> a) Can you name it something other than empty? Maybe basic or something?

Done

> b) Reasonable to loosen up the checks slightly? There's a lot of -NEXT in there that doesn't appear to be strictly necessary (unless you're autogenerating the checks - if so let me know).

Yeah, sort of auto-generating. But do we need to loosen up the checks? This DWARF info should be settled as the result of the tests comes from object files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97186/new/

https://reviews.llvm.org/D97186



More information about the llvm-commits mailing list