[PATCH] D98765: [Polly] Refabricating isReductionParallel() and getMinimalDependenceDistance() from Integer Set Libarary(ISL) to take the C++ wrapper

Wed Mar 17 05:55:57 PDT 2021

Meinersbur added a comment.

Thank for the patch.

Could you change "Refabricating" to "Refactor"? It refers to Code Refactoring <https://en.wikipedia.org/wiki/Code_refactoring>.

================
Comment at: polly/include/polly/CodeGen/IslAst.h:163-164
   /// Get minimal dependence distance or nullptr if not available.
   static __isl_give isl_pw_aff *
-  getMinimalDependenceDistance(__isl_keep isl_ast_node *Node);
+  getMinimalDependenceDistance(const isl::ast_node &Node);

----------------
For the refactoring of this function to be complete, can you also make it return a `isl::pw_aff`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98765/new/

https://reviews.llvm.org/D98765