[PATCH] D98582: [llvm-objcopy][NFC] remove split dwo file creation from executeObjcopyOnBinary.
Alexey Lapshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 17 05:51:54 PDT 2021
avl added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:380-381
+ writeToFile(Config.OutputFilename, ObjcopyFunc,
+ Config.InputFilename != "-" &&
+ Config.InputFilename == Config.OutputFilename,
+ Stat.getUser(), Stat.getGroup()))
----------------
jhenderson wrote:
> I think this should be pulled out into a helper variable, since it's repeated in each instance.
I left this code assuming it would be deleted by by D98511.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98582/new/
https://reviews.llvm.org/D98582
More information about the llvm-commits
mailing list