[PATCH] D98773: [X86] Fix compile time regression of D93594.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:109
   PreheaderBr->setSuccessor(0, Header);
-  DTU.applyUpdatesPermissive({
-      {DominatorTree::Delete, Preheader, Tmp},
-      {DominatorTree::Insert, Header, Body},
-      {DominatorTree::Insert, Body, Latch},
-      {DominatorTree::Insert, Latch, Header},
-      {DominatorTree::Insert, Latch, Exit},
-      {DominatorTree::Insert, Preheader, Header},
-  });
-
-  L->addBasicBlockToLoop(Header, LI);
-  L->addBasicBlockToLoop(Body, LI);
-  L->addBasicBlockToLoop(Latch, LI);
+  if (DT) {
+    DomTreeUpdater DTU(DT, DomTreeUpdater::UpdateStrategy::Lazy);
----------------
This is the key fix.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:120
+  }
+  if (LI) {
+    L->addBasicBlockToLoop(Header, *LI);
----------------
This is the key fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98773/new/

https://reviews.llvm.org/D98773