[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 17 02:59:29 PDT 2021
frasercrmck added a comment.
Looks good to me in general, but I'm similarly not comfortable giving the final approval.
================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:226
+ Value *FirstOp = VPI.getOperand(0);
+ Value *SndOp = VPI.getOperand(1);
+ Value *Mask = VPI.getMaskParam();
----------------
super nit: I'm not sure `FirstOp` and `SndOp` reads very well. I see that `MemoryBuiltins` uses `FstParam` and `SndParam`, but more common would be something like `Op0` and `Op1`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78203/new/
https://reviews.llvm.org/D78203
More information about the llvm-commits
mailing list