[PATCH] D98423: Fix the trunc instruction insertion problem in SLP pass

[Bu Le via Phabricator via llvm-commits]

bule added a comment.

@anton-afanasyev Anton, you might need to help me merge this one as well.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4915
+      // last phi node.
+      if (dyn_cast<PHINode>(I))
+        Builder.SetInsertPoint(&*I->getParent()->getFirstInsertionPt());
----------------
anton-afanasyev wrote:
> isa<PHINode>(I)
done


================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/trunc-insertion.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt  < %s -slp-vectorizer -disable-verify -S | FileCheck %s
 
----------------
bjope wrote:
> I figure the idea is that `-disable-verify` can be removed in this patch.
@anton-afanasyev what do you think? 


================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/trunc-insertion.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt  < %s -slp-vectorizer -disable-verify -S | FileCheck %s
 
----------------
bule wrote:
> bjope wrote:
> > I figure the idea is that `-disable-verify` can be removed in this patch.
> @anton-afanasyev what do you think? 
Remove the -disable-verify option could make the result check more strict. So removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98423/new/

https://reviews.llvm.org/D98423