[PATCH] D98687: Fix demangling of optional template-args for vendor extended type qualifier.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 01:44:01 PDT 2021


jhenderson resigned from this revision.
jhenderson added a comment.

Thanks for the test update - that bit looks good to me. I'm not familiar enough with the demangling code to review the rest, so am resigning as reviewer, in the hope that will clear my "request changes" mark.



================
Comment at: llvm/unittests/Demangle/DemangleTest.cpp:26
+  // Regression test for demangling of optional template-args for vendor
+  // extended type qualifier (https://bugs.llvm.org/show_bug.cgi?id=48009)
+  EXPECT_EQ(demangle("_Z3fooILi79EEbU7_ExtIntIXT_EEi"),
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98687/new/

https://reviews.llvm.org/D98687



More information about the llvm-commits mailing list