[PATCH] D98762: [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks for the patch. Will take a closer look, but at a glance this looks quite good.

`.module` may feel like a GNU as directive. I suggest `.lto_module` so that it is clear the directive is LTO internal stuff.



================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:5844
 
+bool AsmParser::parseDirectiveModule() {
+  if (parseEOL())
----------------
Add some comments about their usage in LTO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98762/new/

https://reviews.llvm.org/D98762