[PATCH] D90831: DebugInfo support for OCaml bindings

[Vaivaswatha Nagaraj via Phabricator via llvm-commits]

vaivaswatha added a comment.

In D90831#2630893 <https://reviews.llvm.org/D90831#2630893>, @vaivaswatha wrote:

> In D90831#2630862 <https://reviews.llvm.org/D90831#2630862>, @vaivaswatha wrote:
>
>> @jberdine: after commit, I found this failure emailed to me `llvm_ocaml.c:function cstr_to_string: error: undefined reference to 'caml_alloc_initialized_string'`. Do you happen to know how I can fix it, because it works on my Ubuntu 20.04 system. What OS do you have? (because you reported that it worked too). A link to one of the build fails I got over email: https://lab.llvm.org/buildbot/#/builders/16/builds/7919
>
> I've now switched to using the following code instead in `cstr_to_string`:
>
>   if (Str) {
>     String = caml_alloc_string(Len);
>     memcpy(String_val(Str), Str, Len);
>   } else {
>     String = caml_alloc_string(0);
>   }

That fixes it: https://github.com/llvm/llvm-project/commit/f7be9db6220cb39f0eaa12d2af3abedf0d86c303


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90831/new/

https://reviews.llvm.org/D90831