[PATCH] D98758: [lld-macho][NFC] Drop unnecessary braces around simple if/for bodies

[Greg McGary via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGa1705336329a: [lld-macho][NFC] Drop unnecessary braces around simple if/for bodies (authored by gkm).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98758/new/

https://reviews.llvm.org/D98758

Files:
  lld/MachO/LTO.cpp
  lld/MachO/MergedOutputSection.cpp
  lld/MachO/OutputSegment.cpp
  lld/MachO/SymbolTable.cpp


Index: lld/MachO/SymbolTable.cpp
===================================================================
--- lld/MachO/SymbolTable.cpp
+++ lld/MachO/SymbolTable.cpp
@@ -54,11 +54,10 @@
           defined->privateExtern &= isPrivateExtern;
         return defined;
       }
-      if (!defined->isWeakDef()) {
+      if (!defined->isWeakDef())
         error("duplicate symbol: " + name + "\n>>> defined in " +
               toString(defined->getFile()) + "\n>>> defined in " +
               toString(file));
-      }
     } else if (auto *dysym = dyn_cast<DylibSymbol>(s)) {
       overridesWeakDef = !isWeakDef && dysym->isWeakDef();
     }
Index: lld/MachO/OutputSegment.cpp
===================================================================
--- lld/MachO/OutputSegment.cpp
+++ lld/MachO/OutputSegment.cpp
@@ -38,9 +38,8 @@
 
 size_t OutputSegment::numNonHiddenSections() const {
   size_t count = 0;
-  for (const OutputSection *osec : sections) {
+  for (const OutputSection *osec : sections)
     count += (!osec->isHidden() ? 1 : 0);
-  }
   return count;
 }
 
Index: lld/MachO/MergedOutputSection.cpp
===================================================================
--- lld/MachO/MergedOutputSection.cpp
+++ lld/MachO/MergedOutputSection.cpp
@@ -45,9 +45,8 @@
 }
 
 void MergedOutputSection::writeTo(uint8_t *buf) const {
-  for (InputSection *isec : inputs) {
+  for (InputSection *isec : inputs)
     isec->writeTo(buf + isec->outSecFileOff);
-  }
 }
 
 // TODO: this is most likely wrong; reconsider how section flags
Index: lld/MachO/LTO.cpp
===================================================================
--- lld/MachO/LTO.cpp
+++ lld/MachO/LTO.cpp
@@ -99,9 +99,8 @@
 
   std::vector<ObjFile *> ret;
   for (unsigned i = 0; i != maxTasks; ++i) {
-    if (buf[i].empty()) {
+    if (buf[i].empty())
       continue;
-    }
     SmallString<261> filePath("/tmp/lto.tmp");
     uint32_t modTime = 0;
     if (!config->ltoObjPath.empty()) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98758.331163.patch
Type: text/x-patch
Size: 1955 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210317/883a0785/attachment.bin>