[PATCH] D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: llvm/test/tools/llvm-dwarfdump/XCOFF/empty.test:180
+; DWARF64:       .debug_str contents:
+; DWARF64-NEXT:  0x00000000: "XL C/C++ for AIX, (IBM Internal Development Branch), clang version 13.0.0"
+; DWARF64-NEXT:  0x0000004a: "empty.c"
----------------
jasonliu wrote:
> Could you add the empty.c test case as comment here and the compile command as well so that people know how to reproduce if needed?
> Also, could we use a public available compiler (xlclang 16.1 / gcc) instead of a self-built compiler to compile this test case for better reproducibility later as well?
Couple of small things:

a) Can you name it something other than empty? Maybe basic or something?

b) Reasonable to loosen up the checks slightly? There's a lot of -NEXT in there that doesn't appear to be strictly necessary (unless you're autogenerating the checks - if so let me know).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97186/new/

https://reviews.llvm.org/D97186