[PATCH] D98323: [lld-macho] implement options -map

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added inline comments.


================
Comment at: lld/test/MachO/map-file.s:30-32
+# CHECK-NEXT: [[#%x,TEXT:]] g     F __TEXT,__text _main
+# CHECK-NEXT: [[#%x,BSS:]] g     O __DATA,__common _number
+# CHECK-NEXT: [[#%x,DATA:]] gw    O __TEXT,obj _foo
----------------
you're re-defining the TEXT/BSS/DATA symbols here (which were already defined on lines 25-27). I know they're the same values since these symbols are at the beginnings of their sections, but I think it would be nicer to define separate names for the symbols (e.g. MAIN, NUMBER, FOO).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98323/new/

https://reviews.llvm.org/D98323