[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 18:45:21 PDT 2021


tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1243
 
 // Prototype f64x2 conversions
 defm "" : SIMDConvert<F32x4, F64x2, int_wasm_demote_zero,
----------------
aheejin wrote:
> If they are finalized, can we delete these "prototype" comments here and elsewhere? (not necessarily in this CL)
Yes, this definitely makes sense. I think I will leave it for future patches that also replace the intrinsics with proper patterns where applicable, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98676/new/

https://reviews.llvm.org/D98676



More information about the llvm-commits mailing list