[PATCH] D98684: [LangRef] state that align assume op bundle may take an extra argument

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 18:36:00 PDT 2021


aqjune marked 3 inline comments as done.
aqjune added a comment.

> the fact that we now have "multiple kinds of arguments" is confusing.

I think it seems okay - the first argument being the value to hold and other arguments being the values passed to the attribute seems clear and explicit.
Unless there exists a case that does not fit in this rule, it looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98684/new/

https://reviews.llvm.org/D98684



More information about the llvm-commits mailing list