[PATCH] D98558: [OPENMP51]Initial support for the interop directive

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 17:26:31 PDT 2021


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14711
+  QualType VarType =
+      InteropVarExpr->getType().getNonLValueExprType(SemaRef.Context);
+  if (!SemaRef.Context.hasSameType(InteropType, VarType)) {
----------------
mikerice wrote:
> ABataev wrote:
> > I don't think you need to call `getNonLValueExprType()` here since `InteropVarExpr` is an expression already.
> Just needs the unqualified type.
 What if `init` clause is applied to `const` qualified var? Is this allowed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98558/new/

https://reviews.llvm.org/D98558



More information about the llvm-commits mailing list