[PATCH] D98558: [OPENMP51]Initial support for the interop directive

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14647
+  // interop construct.
+  llvm::SmallSetVector<const VarDecl *, 4> InteropVars;
+  for (const OMPClause *C : Clauses) {
----------------
Better to use `SmallPtrSet`


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14711
+  QualType VarType =
+      InteropVarExpr->getType().getNonLValueExprType(SemaRef.Context);
+  if (!SemaRef.Context.hasSameType(InteropType, VarType)) {
----------------
I don't think you need to call `getNonLValueExprType()` here since `InteropVarExpr` is an expression already.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98558/new/

https://reviews.llvm.org/D98558