[PATCH] D98230: [LSR] Add reconciliation of unfoldable offsets

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:1976
   UseMapTy UseMap;
+  struct UseUnfOffsMapTy : std::multimap<const SCEV *, size_t> {};
+  UseUnfOffsMapTy UseUnfOffsMap;
----------------
lebedev.ri wrote:
> Should this be `llvm::SmallMapVector<const SCEV *, SmallVector<size_t, 8>, 8>` ?
I agree we should pick the best data structure available, but I would prefer to do wait until we are sure exactly what the patch will look like and then I can do some experiment to figure out the typical need here.

At this point I would first like to have a general opinion about the patch as a whole, please...



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98230/new/

https://reviews.llvm.org/D98230