[PATCH] D90831: DebugInfo support for OCaml bindings

Vaivaswatha Nagaraj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 12:17:21 PDT 2021


vaivaswatha added a comment.

In D90831#2629836 <https://reviews.llvm.org/D90831#2629836>, @jberdine wrote:

> Thanks @vaivaswatha for dealing with all my nitpicking! Yes, I've made a final pass over this and it looks good. I'd recheck the build before committing given the CI build failure.

I checked `ninja check-all` and `ninja check-llvm-bindings-ocaml` locally and they both go fine. The CI build show above in this page, if you click on it shows that the builds succeed and the error is only because of clang-tidy. Since these messages are something that were already there before for the files, I assumed that it's ok to commit. I'm not sure what's the right thing to do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90831/new/

https://reviews.llvm.org/D90831



More information about the llvm-commits mailing list