[PATCH] D98730: [AArch64][GlobalISel] Fall back if disabling neon/fp in the translator.

[Amara Emerson via Phabricator via llvm-commits]

aemerson created this revision.
aemerson added a reviewer: paquette.
aemerson added a project: LLVM.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls, rovka.
aemerson requested review of this revision.

The previous technique relied on early-exiting the legalizer predicate initialization, leaving an empty rule table. That causes a fallback for most instructions, but some have legacy rules defined like G_ZEXT which can try continue, but then crash.

We should fall back earlier, in the translator, to avoid this issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98730

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
  llvm/lib/Target/AArch64/GISel/AArch64CallLowering.h
  llvm/test/CodeGen/AArch64/GlobalISel/no-neon-no-fp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98730.331056.patch
Type: text/x-patch
Size: 4761 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210316/03b7e348/attachment.bin>