[PATCH] D98728: [LICM] Fix a crash when sinking instructions w/token operands

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 11:54:28 PDT 2021


reames added a comment.

In D98728#2629764 <https://reviews.llvm.org/D98728#2629764>, @lebedev.ri wrote:

>> It is not legal to form a phi node with token type.
>
> Can `PHINode::Create()` assert that?

The verifier already catches this pretty promptly.  I don't really see the value in this, but also have no problem landing a separate change to add the assert if desired.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98728/new/

https://reviews.llvm.org/D98728



More information about the llvm-commits mailing list