[PATCH] D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc

Tue Mar 16 11:43:05 PDT 2021

clementval added a comment.

In D93560#2629662 <https://reviews.llvm.org/D93560#2629662>, @Meinersbur wrote:

> The reason why MLIR does not split declaration and implementation-generation might be that nobody yet wanted to invest the work to split them. While I would not request splitting tablegen-generated files into separate files, fusing feels like a step backwards. If only implementation details change, with a merged output everything that includes `OMP.h` must be recompiled as well. I don't see how a separation into declaration and implementation causes the number of files to explode.

We are not fusing header and implementation. We had initially 3 files and after comments from a previous patch it was recommended to reduce that to two files. So after this patch you will have one header file and the implementation with the different code block.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93560/new/

https://reviews.llvm.org/D93560